【PaddlePaddle Hackathon 5th No.42】转换规则第一组 #301

zrr1999 · 2023-09-25T12:24:21Z

PR Docs

https://github.com/PaddlePaddle/docs/pull/5751/files#diff-4edc87fd8fe3db15402459c161ba90be7f26cb3ffd4d25612e8bbc386442059d

PR APIs

torch.Tensor.tile
torch.Tensor.to_sparse
torch.Tensor.quantile
torch.nanquantile
torch.Tensor.stft
torch.stft

paddle-bot · 2023-09-25T12:24:25Z

Thanks for your contribution!

zrr1999 · 2023-09-26T03:32:55Z

@zhwesky2010 您好麻烦看一下stft，精度好像有些问题，差距有点大，但是我在本地是可以通过的，其他部分没有问题

zhwesky2010 · 2023-09-26T03:43:01Z

@zhwesky2010 您好麻烦看一下stft，精度好像有些问题，差距有点大，但是我在本地是可以通过的，其他部分没有问题

CI上是CPU的版本，你本地用CPU试一下，另外每一组有约20个API，这一组其他的呢

paconvert/api_mapping.json

zhwesky2010 · 2023-09-26T03:55:02Z

paconvert/api_matcher.py

+        if kwargs is None:
+            return None
+
+        if "reps" in kwargs:


还有一个支持可变参数的写法，例如：

reps=2, 3, 4 x.tile(*reps)

这里我目前测试，可变参数的写法应该是已经支持的，参考的TensorPermuteMatcher

这里我目前测试，可变参数的写法应该是已经支持的，参考的TensorPermuteMatcher

参考最新的TensorPermuteMatcher，已经重构到更好写法了。
另外本地测试不具有说明性，必须要在单测中添加相应测试，test_Tensor_tile目前的测试是很不全的

paconvert/api_matcher.py

zhwesky2010 · 2023-09-26T03:59:27Z

paconvert/api_matcher.py

+        return code
+
+
+class StftMatcher(BaseMatcher):


这两个合并到一块吧，像这样加个判断：

zhwesky2010 · 2023-09-26T04:01:48Z

tests/test_Tensor_quantile.py

+    pytorch_code = textwrap.dedent(
+        """
+        import torch
+        result = torch.tensor([0., 1., 2., 3.],dtype=torch.float64).quantile(0.6, dim=None, keepdim=False)


dim输入实际值

zhwesky2010 · 2023-09-26T04:02:17Z

tests/test_Tensor_quantile.py

+obj = APIBase("torch.Tensor.quantile")
+
+
+def test_case_1():


参考单测规范，测试内容不全：

https://github.com/PaddlePaddle/PaConvert/blob/master/docs/CONTRIBUTING.md#%E6%AD%A5%E9%AA%A45%E7%BC%96%E5%86%99%E5%8D%95%E5%85%83%E6%B5%8B%E8%AF%95

zhwesky2010 · 2023-09-26T04:02:32Z

tests/test_Tensor_stft.py

+           (0.13631296157836914+0j)                ,
+          (-0.19927024841308594+0j)                ,
+           (0.19927024841308594+0j)                ]])
+        result = x.stft(n_fft=4, onesided=False, return_complex=True)


zhwesky2010 · 2023-09-26T04:05:21Z

tests/test_Tensor_tile.py

+    )
+
+
+def test_case_2():


同上，测试内容不全

参考test_Tensor_reshape的测试

zhwesky2010 · 2023-09-26T04:06:36Z

tests/test_nanquantile.py

+def test_case_4():
+    pytorch_code = textwrap.dedent(
+        """
+        import torch


同上，测试内容补全，dim请输入实际值，不能刻意绕过问题

已修改添加

zhwesky2010 · 2023-09-26T04:06:46Z

tests/test_stft.py

+obj = APIBase("torch.stft")
+
+
+def test_case_1():


zrr1999 · 2023-09-26T04:37:26Z

@zhwesky2010 您好麻烦看一下stft，精度好像有些问题，差距有点大，但是我在本地是可以通过的，其他部分没有问题

CI上是CPU的版本，你本地用CPU试一下，另外每一组有约20个API，这一组其他的呢

这一部分是由文档的部分，其他的需要我先去补充下文档合入后，再作为第二个pr提交

zhwesky2010 · 2023-10-11T09:07:12Z

paconvert/api_matcher.py

+        if kwargs is None:
+            return None
+
+        if "reps" in kwargs:


这里我目前测试，可变参数的写法应该是已经支持的，参考的TensorPermuteMatcher

参考最新的TensorPermuteMatcher，已经重构到更好写法了。
另外本地测试不具有说明性，必须要在单测中添加相应测试，test_Tensor_tile目前的测试是很不全的

zhwesky2010 · 2023-10-11T09:08:44Z

tests/test_Tensor_tile.py

@@ -30,6 +30,18 @@ def test_case_1():
    obj.run(
        pytorch_code,
        ["result"],
-        unsupport=True,
-        reason="Paddle not support this api convert now",
+    )


参考最新的test_Tensor_permute测试，包含十几种用例

zhwesky2010 · 2023-10-11T09:11:52Z

@zrr1999 PR未通过单测测试，另外已经有文档的需要全部检查一下，如果有问题也需要修正。

luotao1 · 2023-11-13T08:26:19Z

@zrr1999 转换规则第1组只剩下 torch.stft

【Hackathon 5th No.42】为Paddle代码转换工具新增API转换规则 (第1组编号1-20) #318 (comment)

@Li-fAngyU 这个PR里有 torch.stft 的处理，看看能否合作？

zrr1999 added 2 commits September 25, 2023 20:16

add tile

3c4e5dc

add to_sparse

54d18ba

paddle-bot bot added the contributor External developers label Sep 25, 2023

zrr1999 marked this pull request as ready for review September 25, 2023 12:57

zrr1999 changed the title ~~转换规则 torch.Tensor.tile, torch.Tensor.to_sparse~~ 【PaddlePaddle Hackathon 5th】转换规则 torch.Tensor.tile, torch.Tensor.to_sparse Sep 25, 2023

zrr1999 changed the title ~~【PaddlePaddle Hackathon 5th】转换规则 torch.Tensor.tile, torch.Tensor.to_sparse~~ 【PaddlePaddle Hackathon 5th No. 42】转换规则 torch.Tensor.tile, torch.Tensor.to_sparse Sep 25, 2023

zrr1999 changed the title ~~【PaddlePaddle Hackathon 5th No. 42】转换规则 torch.Tensor.tile, torch.Tensor.to_sparse~~ 【PaddlePaddle Hackathon 5th No.42】转换规则 torch.Tensor.tile, torch.Tensor.to_sparse Sep 25, 2023

zrr1999 added 5 commits September 25, 2023 21:41

add TensorTileMatcher and fix bug

f068312

add test

67def81

add quantile

a6bc905

fix quantile

1e2ee48

fix test

c113a68

zrr1999 changed the title ~~【PaddlePaddle Hackathon 5th No.42】转换规则 torch.Tensor.tile, torch.Tensor.to_sparse~~ 【PaddlePaddle Hackathon 5th No.42】转换规则 torch.Tensor.tile, torch.Tensor.to_sparse, torch.Tensor.quantile Sep 25, 2023

add nanquantile

44b9c33

zrr1999 changed the title ~~【PaddlePaddle Hackathon 5th No.42】转换规则 torch.Tensor.tile, torch.Tensor.to_sparse, torch.Tensor.quantile~~ 【PaddlePaddle Hackathon 5th No.42】转换规则第一组 Sep 25, 2023

zrr1999 added 4 commits September 25, 2023 23:01

add stft

d630ccf

add stft

18a74eb

add more test

e55b000

fix

5ddef1a

zhwesky2010 reviewed Sep 26, 2023

View reviewed changes

luotao1 assigned luotao1 and zhwesky2010 Sep 26, 2023

add more test

d517855

zrr1999 added 2 commits September 26, 2023 16:17

add min_input_args

414768f

change tol

636da87

Ligoml mentioned this pull request Sep 26, 2023

【PaddlePaddle Hackathon 5th】开源贡献个人挑战赛 PaddlePaddle/Paddle#57262

Open

zhwesky2010 reviewed Oct 11, 2023

View reviewed changes

Li-fAngyU mentioned this pull request Oct 23, 2023

【Hackathon 5th No.42】为Paddle代码转换工具新增API转换规则 (第1组编号1-20) #318

Merged

luotao1 closed this Nov 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

【PaddlePaddle Hackathon 5th No.42】转换规则第一组 #301

【PaddlePaddle Hackathon 5th No.42】转换规则第一组 #301

zrr1999 commented Sep 25, 2023 •

edited

Loading

paddle-bot bot commented Sep 25, 2023

zrr1999 commented Sep 26, 2023

zhwesky2010 commented Sep 26, 2023

zhwesky2010 Sep 26, 2023

zrr1999 Sep 26, 2023

zhwesky2010 Oct 11, 2023

zhwesky2010 Sep 26, 2023

zrr1999 Sep 26, 2023

zhwesky2010 Sep 26, 2023

zrr1999 Sep 26, 2023

zhwesky2010 Sep 26, 2023

zhwesky2010 Sep 26, 2023

zhwesky2010 Sep 26, 2023

zhwesky2010 Sep 26, 2023

zrr1999 Sep 26, 2023

zhwesky2010 Sep 26, 2023

zrr1999 commented Sep 26, 2023

zhwesky2010 Oct 11, 2023

zhwesky2010 Oct 11, 2023

zhwesky2010 commented Oct 11, 2023 •

edited

Loading

luotao1 commented Nov 13, 2023

【PaddlePaddle Hackathon 5th No.42】转换规则 第一组 #301

【PaddlePaddle Hackathon 5th No.42】转换规则 第一组 #301

Conversation

zrr1999 commented Sep 25, 2023 • edited Loading

PR Docs

PR APIs

paddle-bot bot commented Sep 25, 2023

zrr1999 commented Sep 26, 2023

zhwesky2010 commented Sep 26, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zrr1999 commented Sep 26, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhwesky2010 commented Oct 11, 2023 • edited Loading

luotao1 commented Nov 13, 2023

【PaddlePaddle Hackathon 5th No.42】转换规则第一组 #301

【PaddlePaddle Hackathon 5th No.42】转换规则第一组 #301

zrr1999 commented Sep 25, 2023 •

edited

Loading

zhwesky2010 commented Oct 11, 2023 •

edited

Loading